apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Curt Arnold <carn...@apache.org>
Subject Re: Gump failures on apr-iconv and apr-util since 2005-11-10
Date Thu, 22 Dec 2005 19:32:45 GMT

On Dec 22, 2005, at 12:03 PM, Garrett Rooney wrote:

> On 12/22/05, Curt Arnold <carnold@apache.org> wrote:
>
>>
>> It would still be very nice to get that one line fixed in apr-iconv
>> since apr-util is a dependency for log4cxx.   As long as apr-util is
>> not being built by Gump, neither is log4cxx and it eliminates the
>> only continuous integration system that reports our build status to
>> our list.
>
> Umm, as far as I can tell apr-iconv isn't even listed as a dependency
> for apr-util in the gump metadata, it is listed as one for
> logging-log4cxx though.  Perhaps removing the dependency from log4cxx
> would allow things to continue.  I mean it seems like apr-util should
> be picking up the system iconv anyway, since nothing in its metadata
> file indicates that it's using apr-iconv at all.

The apr-util build fails due to the same line which is involved in  
the build for both projects.  Could likely drop the apr-iconv  
dependency for log4cxx now, but would still be stopped since apr-util  
isn't building.

>
> Anyway, you have two options, either provide a patch for apr-iconv
> that fixes the problem (which I will happily review and apply), or
> alter the gump metadata so that you no longer depend on it.
>


I concur with the suggested change in http://issues.apache.org/ 
bugzilla/show_bug.cgi?id=37650.  My message on it was http:// 
marc.theaimsgroup.com/?l=apr-dev&m=113511544618645&w=2.

Index: lib/iconv_ces_euc.c
===================================================================
--- lib/iconv_ces_euc.c	(revision 358113)
+++ lib/iconv_ces_euc.c	(working copy)
@@ -62,7 +62,7 @@
	state->nccs = ces->mod->im_depcnt;
	for (i = ces->mod->im_depcnt; i; i--, depmod = depmod->im_next)
		state->ccs[i - 1] = depmod;
-	CESTOSTATE(ces) = state;
+	ces->data = state;
	return APR_SUCCESS;
}


Mime
View raw message