apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: PR#28453: apr_uri
Date Wed, 28 Dec 2005 11:12:03 GMT
On Wednesday 28 December 2005 11:04, Nick Kew wrote:
> PR#28453 contains a patch to parse URIs relative to a base URI supplied.
> Anyone object if I apply it (with any updates necessary - seems to
> contain tabs)?

Hmmm, pasting the API of that patch, I notice both functions incorrectly
return int for apr_status_t.  A quick look at the current apr_uri in /trunk/
shows it does the same: the functions are declared and documented
as returning int, but in fact return APR_SUCCESS/APR_EGENERAL.

Worth fixing at the same time, IMO.

Nick Kew

View raw message