apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: [PATCH] Move 'acceptable' check inside find m4s
Date Sun, 11 Dec 2005 19:44:28 GMT
On Sun, Dec 11, 2005 at 07:29:09PM +0000, Joe Orton wrote:
> Doing the version check using APACHE_CHECK_APxVER that early doesn't 
> work, it breaks like PR 37283.  I don't entirely undestand why but 
> APACHE_CHECK_APxVER could be written to use `ap*-config --version` 
> instead of CPP checks to avoid that, probably.

That's just a convienent example macro, it's httpd anyway :) We can fix
it easily enough.

> In concept I'm not convinced this is a good idea anyway.  
> 
> Say I have APR version X installed in standard prefix /usr/local/apr, 
> and a bunch of applications built which link against that.  When I go to 
> upgrade any of those applications, I want the app to either continue 
> using that standard system APR or fail to build and tell me if I have to 
> upgrade to APR version Y instead.  I don't want each app to instead 
> install its own bundled copy of APR and end up with N different APR 
> installs in different prefixes.

Each app can make that decision, we'll set apr_acceptable to no in that
circumstance, which will let the apps build system decide either to bomb
out, warn the user or continue on regardless. We already bomb out for
the --with-apr case.

A potential problem area is the case where /usr/bin/apr-1-config is
unacceptable but /usr/local/bin/apr-1-config isn't, and that might go
against the user's expectations, but they should really use --with-apr
if they have multiple aprs in standard locations.

As an asside, I think we should remove /usr/local/apache2/ as a 
"standard" location.

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message