Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Wed, 2 Nov 2005 11:12:37 +0000
From: Joe Orton <jorton@redhat.com>
To: dev@apr.apache.org
Subject: Re: svn commit: r330141 - /apr/apr-util/trunk/dbd/apr_dbd.c
Message-ID: <20051102111237.GA26013@redhat.com>
Mail-Followup-To: dev@apr.apache.org
References: <20051101224046.74894.qmail@minotaur.apache.org>
 <200511012354.18910@news.perlig.de> <20051102090307.GA21816@redhat.com>
 <200511021107.23736.nick@webthing.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <200511021107.23736.nick@webthing.com>
User-Agent: Mutt/1.4.2.1i

On Wed, Nov 02, 2005 at 11:07:21AM +0000, Nick Kew wrote:
> On Wednesday 02 November 2005 09:03, Joe Orton wrote:
> 
> > This code has undefined behaviour by the C standard (calling a function
> > via a function pointer of incompatible type), such casts should never be
> > used at all IMO.
> 
> So where is the incompatible pointer type?

(apr_status_t (*)(apr_thread_mutex_t *)) is not compatible with 
(apr_status_t (*)(void *)), likewise for the ->end_transaction callback.  
If it was compatible the cast wouldn't be needed.

joe