apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: [PATCH] Re: APR with SCTP streams.
Date Tue, 22 Nov 2005 16:50:36 GMT
On Tue, Nov 22, 2005 at 11:31:18AM -0500, Preethi Natarajan wrote:
> Would you prefer that I attach a new patch with 
> apr_parse_addr_port_protocol() removed?

I've been testing your patch, and no problems so far. I havn't found the
time to fix the small portability problems though. What would be really
useful is the same patch, with the problems fixed, which are small;

	* apr_parse_addr_port_protocol() removed

	* The @ taken out of the e-mail address in the CHANGES entry

	* bzero calls changed to memset calls

	* Remove the tabs and replace with spaces, consistently 
	  indent the code in general.

	* Remove the superflous arv variable (as far as I can tell
	  this was needed when there was a while loop, but not any
	  more).

At least they're what are in my notes :-) I'll get round to them myself
at some point too.

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message