apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] don't reference revents from poll() if no events were met
Date Sun, 02 Oct 2005 11:34:49 GMT
On 10/1/05, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> On 10/1/05, Jeff Trawick <trawick@gmail.com> wrote:
> > Purify on Solaris pointed out that we were referencing uninitialized
> > storage when checking revents.  It was uninitialized (by kernel/libc)
> > because no conditions were met.
> >
> > Concerns?
>
> The comment should be "caller should look at revents", not
> "rtnevents".

Actually I meant the caller of apr_poll().  But that sort of guidance
is better placed in the documentation (which I'll do).

>                               Also, it seems like you could
> compare against i, not *nsds, and avoid having to dereference a
> pointer

will-do

Thanks for the comments!

Mime
View raw message