apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mark benedetto king <...@spork.local>
Subject [PATCH] Fix APR_SSIZE_T_FMT on Darwin.
Date Sun, 02 Oct 2005 14:43:07 GMT
Currently, configure generates "%d" for APR_SSIZE_T_FMT on Darwin.
This leads to the following warning with gcc -Wall on OS X 10.4:

warning: format '%d' expects type 'int', but argument N has type
'apr_ssize_t'

When APR_SSIZE_T_FMT is defined to "%ld", warnings are not generated.
Also, I believe that "%ld" is more consistent with the choice of "%lu"
for APR_SIZE_T_FMT.

[[
Make configure generate "%ld" for APR_SSIZE_T_FMT on Darwin.
]]

Index: configure.in
===================================================================
--- configure.in	(revision 263866)
+++ configure.in	(working copy)
@@ -1349,7 +1349,7 @@
         size_t_fmt='#define APR_SIZE_T_FMT "ld"'
         ;;
     *apple-darwin*)
-        ssize_t_fmt='#define APR_SSIZE_T_FMT "d"'
+        ssize_t_fmt='#define APR_SSIZE_T_FMT "ld"'
         size_t_fmt='#define APR_SIZE_T_FMT "lu"'
         ;;
 esac

Mime
View raw message