apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: [PATCH] Configurable read/write buffer sizes
Date Fri, 09 Sep 2005 13:57:40 GMT

O.k., I've done some new patches and a few read throughs to think the
implications of a large buffer size out, and implemented a flags-capable
variant of the stdin/out/err openers. 

I believe apr_size_t is safe, apart from the circumstance where someone
tries to assign a vlue to the buffer size that would overflow an
apr_size_t anyway, so not worth worrying about.

The patches are all at;


They are all against trunk, but can be applied in sequence, there's only
one slight offset change that patch has to figure out.

    000-stderr-docfix.patch     Fixes a doxygen documentation nit, someone
                                please just commit this ;-)

    001-flags-stdio.patch 	Implement apr_file_open_flags_std(err|out|in)
                                Nothing major, but I've also set APR_READ
                                or APR_WRITE as appropriate, purely for the
                                sake of apr_file_flags_get();

    002-set-buffer.patch        APR-wide changes to implement 
                                apr_file_set_buffer() and apr_file_buffer_size_get(),
                                includes a testcase

    003-set-buffer-unix.patch   Unix implementation of same, tested on Ubuntu

    004-set-buffer-win32.patch  Win32 implementation, tested w2k3. I didn't include
                                the changes to the dsp files, because VS2005 to behave.

    005-set-buffer-netware.patch Netware header changes neccessary, untested

    006-set-buffer-os2.patch    OS implementation, untested, based on inspection	

Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

View raw message