Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (asf.osuosl.org: local policy)
Message-ID: <42F92276.1080705@electricjellyfish.net>
Date: Tue, 09 Aug 2005 14:39:02 -0700
From: Garrett Rooney <rooneg@electricjellyfish.net>
User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317)
MIME-Version: 1.0
To: Nick Kew <nick@webthing.com>
CC: dev@apr.apache.org
Subject: Re: apr_dbd
References: <42F0F44F.9010100@webthing.com>
 <200508092102.37286.nick@webthing.com>
 <42F91320.6090007@electricjellyfish.net>
 <200508092227.44493.nick@webthing.com>
In-Reply-To: <200508092227.44493.nick@webthing.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Nick Kew wrote:
> On Tuesday 09 August 2005 21:33, Garrett Rooney wrote:
> 
>>Nick Kew wrote:
>>
>>>Anyway, as I said, a placeholder now fixes that.
>>
>>Out of curiosity, is there any reason we can't just forward declare the
>>struct and access the internals via some accessor functions?
> 
> 
> Hmmm, fair point.
> 
> There's one definite stumbling block there: the varargs APIs.
> Can the vararg functions (specifically, the pvquery and pvselect
> functions) be expressed as apr_dbd #defines, like the rest of
> the calls?  Anyone?

Why does that matter?  My suggestion doesn't involve any wrapper 
defines, just functions...

in apr_dbd.h:

typedef struct apr_dbd_driver_t apr_dbd_driver_t;

apr_status_t apr_dbd_func_that_takes_varargs(apr_dbd_driver_t *d, ...);

in driver.c

struct apr_dbd_driver_t {
   /* stuff */
};

apr_status_t apr_dbd_func_that_takes_varargs(apr_dbd_driver_t *d, ...)
{
   // turn ... into va_list
   return d->func(my_va_list);
}

I don't see the need for the macros at all...

-garrett