From dev-return-14540-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Aug 10 16:47:59 2005 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 54561 invoked from network); 10 Aug 2005 16:47:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 Aug 2005 16:47:58 -0000 Received: (qmail 19824 invoked by uid 500); 10 Aug 2005 16:47:57 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 19785 invoked by uid 500); 10 Aug 2005 16:47:56 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 19772 invoked by uid 99); 10 Aug 2005 16:47:56 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2005 09:47:56 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [209.68.5.17] (HELO relay03.pair.com) (209.68.5.17) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 10 Aug 2005 09:48:16 -0700 Received: (qmail 53683 invoked from network); 10 Aug 2005 16:47:51 -0000 Received: from unknown (HELO ?10.0.100.15?) (unknown) by unknown with SMTP; 10 Aug 2005 16:47:51 -0000 X-pair-Authenticated: 206.80.1.253 Message-ID: <42FA2DD2.6090404@electricjellyfish.net> Date: Wed, 10 Aug 2005 09:39:46 -0700 From: Garrett Rooney User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@apr.apache.org Subject: Re: svn commit: r231136 - in /apr/apr-util/trunk: dbd/apr_dbd.c dbd/apr_dbd_internal.h include/apr_dbd.h References: <20050809231510.81949.qmail@minotaur.apache.org> In-Reply-To: <20050809231510.81949.qmail@minotaur.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N niq@apache.org wrote: > + /** pvquery: query using a prepared statement + args > + * > + * @param pool - working pool > + * @param handle - the connection > + * @param nrows - number of rows affected. > + * @param statement - the prepared statement to execute > + * @param ... - args to prepared statement > + * @return 0 for success or error code > + */ > + int (*pvquery)(apr_pool_t *pool, apr_dbd_t *handle, int *nrows, > + apr_dbd_prepared_t *statement, ...); > + > + /** pvselect: select using a prepared statement + args > + * > + * @param pool - working pool > + * @param handle - the connection > + * @param res - pointer to query results. May point to NULL on entry > + * @param statement - the prepared statement to execute > + * @param random - Whether to support random-access to results > + * @param ... - args to prepared statement > + * @return 0 for success or error code > + */ > + int (*pvselect)(apr_pool_t *pool, apr_dbd_t *handle, > + apr_dbd_results_t **res, > + apr_dbd_prepared_t *statement, int random, ...); Since when we call this in apr_dbd.c we pass a va_list to it, shouldn't we declare it as taking a va_list instead of ...? That's what apr_pvsprintf does, for example. I suspect if this is working then it's by accident, and I'm not sure we can depend on it working correctly on all platforms. -garrett