apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: TCP_CORK in Linux 2.6: not broken, but it doesn't work with TCP_NODELAY
Date Tue, 23 Aug 2005 19:25:55 GMT
--On August 23, 2005 4:51:52 PM +0100 Joe Orton <jorton@redhat.com> wrote:

> Since 2.6 can enable both TCP_CORK and TCP_NODELAY at the same time, and
> TCP_CORK will take precedence, APR can save two syscalls in the critical
> path.  Objections?

Looks fine.  One question: how does this apply to other OSes which also 
have TCP_NOPUSH and TCP_NODELAY (such as FreeBSD)?

FWIW, I just couldn't make sense of the way that diff split up the context 
without applying the patch locally and reading the new function.   -- justin

Mime
View raw message