apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@xbc.nu>
Subject Re: Locale problem with filename handling in Mac OS X
Date Tue, 23 Aug 2005 02:01:05 GMT
Kenneth Falck wrote:

> The simplest fix to this would look something like this (file_io/unix/ 
> filepath.c):
>
> APR_DECLARE(apr_status_t) apr_filepath_encoding(int *style,  
> apr_pool_t *p)
> {
> #ifdef DARWIN
>     *style = APR_FILEPATH_ENCODING_UTF8;
> #else
>     *style = APR_FILEPATH_ENCODING_LOCALE;
> #endif
>     return APR_SUCCESS;
> }

This fix looks correct; it's essentially the same as what we do on Windows.

Regarding the implementation, I believe the default value should be 
autoconf'd , not #ifdef'd in the code.

-- Brane


Mime
View raw message