apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garrett Rooney <roo...@electricjellyfish.net>
Subject Re: [PATCH] fixing bogus apr_date_parse_rfc()
Date Fri, 19 Aug 2005 04:05:57 GMT
Maxime Petazzoni wrote:
> Hi,
> 
> I'm answering to myself in order to submit an updated version of my
> patch, fixing the original distance bug, but also adding support for
> another space+one-digit day format (for the two-digit year formats).
> 
> Some code style fixes are also included in this patch. If you don't like
> the mix of bug fixing, enhancements and code style fixes, I can split
> this patch into several patches to clarify all this stuff.
> 
> Comments and reviews are, of course, very welcome. I hope this patch can
> be part of the just-released apr-util.

Well, the fact that it's "just-released" implies that it won't make 
it...  But I suspect it'll be in the next one.

Committed in revision 233425.

Note that in order to make the diff readable I had to remove the many 
whitespace changes.  I don't have any objection to fixing things like 
trailing whitespace, but please submit those changes as a separate diff 
as they make it difficult to tell what parts of a patch are actual 
changes in functionality and what part are just whitespace.

I also converted your testdaterfc.c file into an abts style test suite.

Thanks,

-garrett

Mime
View raw message