apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Garrett Rooney <roo...@electricjellyfish.net>
Subject Re: svn commit: r231136 - in /apr/apr-util/trunk: dbd/apr_dbd.c dbd/apr_dbd_internal.h include/apr_dbd.h
Date Wed, 10 Aug 2005 17:12:22 GMT
Nick Kew wrote:
> Garrett Rooney wrote:
> 
>>
>> Since when we call this in apr_dbd.c we pass a va_list to it, 
>> shouldn't we declare it as taking a va_list instead of ...?  That's 
>> what apr_pvsprintf does, for example.  I suspect if this is working 
>> then it's by accident, and I'm not sure we can depend on it working 
>> correctly on all platforms.
> 
> 
> Very probably.  I don't claim to understand the intricacies of varargs.
> If you know better how to deal with it, please fix as appropriate.
> 

Ok, I'll take a look at it tonight.

-garrett

Mime
View raw message