apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] Fix loop termination in apr_file_write
Date Mon, 22 Aug 2005 09:55:14 GMT
On Sun, Aug 21, 2005 at 04:36:51PM +0200, Erik Huelsmann wrote:
> On 8/20/05, Joe Orton <jorton@redhat.com> wrote:
> 
> > > I promissed Karl Fogel a reproduction recipe, but didn't succeed in
> > > creating one. OTOH, I think it's clear the line needs changing...
> > 
> > I've committed this with a test case (trying to write to a file which
> > was opened read-only), thanks Erik.
> 
> Welcome.
> 
> Given that this is not only a problem for Subversion clients, but also
> for mod_dav_svn and svnserve servers [which are short on /tmp disc
> space for example], I'd like to ask for a backport to 0.9.x and a

Yes, sure - there are a couple of other places where the 
apr_file_flush() return value is ignored in the same file - I'd like to 
fix those too, just need to write some more test cases first.

joe

Mime
View raw message