apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxime Petazzoni <maxime.petazz...@bulix.org>
Subject Re: [PATCH] fixing bogus apr_date_parse_rfc()
Date Fri, 19 Aug 2005 08:31:12 GMT
Hi,

> Note that in order to make the diff readable I had to remove the many 
> whitespace changes.  I don't have any objection to fixing things like 
> trailing whitespace, but please submit those changes as a separate diff 
> as they make it difficult to tell what parts of a patch are actual 
> changes in functionality and what part are just whitespace.

I asked if you wanted me to split the patch ... Anyway, thanks a lot for
the review and tweaking.

> I also converted your testdaterfc.c file into an abts style test suite.

Thanks for this, testdaterfc is a very simple ABTS example. I didn't see
any documentation or tutorial on writing an ABTS test, are you
interested in a short HOWTO based on the testdaterfc example ?

- Sam

-- 
Maxime Petazzoni (http://www.bulix.org)
 -- gone crazy, back soon. leave message.

Mime
View raw message