Hi Garrett,
Sure, no problem.
1) relock the mutex after a retry in the
dbd_sqlite3_select function.
2) remove break from the return of a float value from
SQLite and initialize the value to NULL. The value was
never being returned.
3) remove unnecessary creation and destruction of
apr_pool in dbd_sqlite3_query function.
4) Remove the res variable in the dbd_sqlite3_query
function.
There were some changes after this review and the
updated patch file is attached.
Thanks,
Rick Keiner
--- Garrett Rooney <rooneg@electricjellyfish.net>
wrote:
> Rick Keiner wrote:
> > Hi Paul,
> >
> > I've attached a patch to the SQLite 3 driver that
> > fixes some initialization issues and returns float
> > data. This has been tested with the
> jxta-c.jxta.org
> > project and no major issues. If we could get it in
> the
> > release that would be great! We are relying on
> this
> > patch to be part of the release.
>
> I'd love to commit this patch, but it seems to do a
> number of different
> things, and since I don't know all that much about
> the internals of the
> sqlite3 dbd I can't confirm if they're right or
> wrong. Could you
> perhaps write a log message that explains exactly
> what problems are
> being corrected here (in addition to the addition of
> the new float data
> feature).
>
> Thanks,
>
> -garrett
>
|