Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 44177 invoked from network); 6 Jul 2005 12:55:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Jul 2005 12:55:29 -0000 Received: (qmail 59642 invoked by uid 500); 6 Jul 2005 12:55:27 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 59606 invoked by uid 500); 6 Jul 2005 12:55:26 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 59590 invoked by uid 99); 6 Jul 2005 12:55:26 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jul 2005 05:55:26 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [209.133.199.10] (HELO jimsys.jagunet.com) (209.133.199.10) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jul 2005 05:55:26 -0700 Received: from [127.0.0.1] (localhost [127.0.0.1]) by jimsys.jagunet.com (Postfix) with ESMTP id 0D1275F2F75; Wed, 6 Jul 2005 08:55:22 -0400 (EDT) In-Reply-To: <20050705161033.GA17811@redhat.com> References: <20050705161033.GA17811@redhat.com> Mime-Version: 1.0 (Apple Message framework v730) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <6DEE1F44-AED5-465A-8BAF-BA47B1D06492@apache.org> Cc: dev@apr.apache.org Content-Transfer-Encoding: 7bit From: Jim Jagielski Subject: Re: [PATCH] vformatter formatting apr_status_t Date: Wed, 6 Jul 2005 08:55:21 -0400 To: Joe Orton X-Mailer: Apple Mail (2.730) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Jul 5, 2005, at 12:10 PM, Joe Orton wrote: > Since 1.2.0 already adds one of these, why not another... > > glibc has a %m format string which is which expands to strerror(); > this > adds an equivalent %%pm which takes a pointer to an apr_status_t and > prints the appropriate error string for that error code. > > This is really nice to use on error paths, where you can collapse the > typical "apr_psprintf + apr_strerror into a stack buffer" sequence > into > a single apr_psprintf call with no stack buffer needed. > > Objections? > Nope, +1