Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 81341 invoked from network); 22 Jul 2005 19:37:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Jul 2005 19:37:29 -0000 Received: (qmail 51083 invoked by uid 500); 22 Jul 2005 19:37:20 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 50844 invoked by uid 500); 22 Jul 2005 19:37:19 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 50827 invoked by uid 99); 22 Jul 2005 19:37:19 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jul 2005 12:37:18 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=HTML_20_30,HTML_MESSAGE X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [68.142.200.65] (HELO web30002.mail.mud.yahoo.com) (68.142.200.65) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 22 Jul 2005 12:37:12 -0700 Received: (qmail 67693 invoked by uid 60001); 22 Jul 2005 19:37:15 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:Received:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=j+3SxDVxHJNWog+6Ro2jpVsvwuyC/JFXGWWQ9X2o+eyXut1bSOt8J2niLnK+evZejMAlujKdhu+T6AjdAcCVDEtdEIlqg25TvU4aLYv0TPH/jg12NTorkEIFrzEbjI/OWFg4SeoL5i1V1fXVK2FrVeXxZ9IhL0mlTMu5mJLJmCA= ; Message-ID: <20050722193715.67691.qmail@web30002.mail.mud.yahoo.com> Received: from [64.192.136.9] by web30002.mail.mud.yahoo.com via HTTP; Fri, 22 Jul 2005 12:37:15 PDT Date: Fri, 22 Jul 2005 12:37:15 -0700 (PDT) From: E Holyat Subject: Re: [VOTE] APR 1.2.0 To: "William A. Rowe, Jr." , Henry Jen Cc: dev@apr.apache.org In-Reply-To: <6.2.1.2.2.20050721124607.08595480@pop3.rowe-clan.net> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="0-1159615440-1122061035=:66760" Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --0-1159615440-1122061035=:66760 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit I did some testing without the extra mutex, and it looks good to go. Due to the UNIX documentation for the pthread signalling(that Henry pointed out), the behavior is the same. "William A. Rowe, Jr." wrote:At 04:56 PM 7/20/2005, Henry Jen wrote: >Good catch, you also need to reset cond->signalled. >I adapted your changes on the "else if" also the static INLINE internal function and created a new patch. This is definitely coolness; do you two agree this is the complete patch for locks/win32/thread_cond.c? If so, I'll commit this flavor in a couple hours after you both look it over one last time. I'm afraid, never having used condvars, that I'm not 100% certain about the expected behavior, so I'm not the best reviewer. Thanks to you both for spending cycles examining this code. FYI - in the future be careful to tag [PATCH apr-1.2] or something in the subject so that patches aren't lost in the noise of a longer conversation. Bill --------------------------------- Start your day with Yahoo! - make it your home page --0-1159615440-1122061035=:66760 Content-Type: text/html; charset=iso-8859-1 Content-Transfer-Encoding: 8bit
 
I did some testing without the extra mutex, and it looks good to go.  Due to the UNIX documentation for the pthread signalling(that Henry pointed out), the behavior is the same.

"William A. Rowe, Jr." <wrowe@rowe-clan.net> wrote:
At 04:56 PM 7/20/2005, Henry Jen wrote:

>Good catch, you also need to reset cond->signalled.
>I adapted your changes on the "else if" also the static INLINE internal function and created a new patch.

This is definitely coolness; do you two agree this is the complete
patch for locks/win32/thread_cond.c? If so, I'll commit this flavor
in a couple hours after you both look it over one last time.

I'm afraid, never having used condvars, that I'm not 100% certain
about the expected behavior, so I'm not the best reviewer. Thanks
to you both for spending cycles examining this code.

FYI - in the future be careful to tag [PATCH apr-1.2] or something
in the subject so that patches aren't lost in the noise of a longer
conversation.

Bill

Start your day with Yahoo! - make it your home page --0-1159615440-1122061035=:66760--