From dev-return-14450-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Jul 21 18:16:11 2005 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 26269 invoked from network); 21 Jul 2005 18:16:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 21 Jul 2005 18:16:10 -0000 Received: (qmail 33394 invoked by uid 500); 21 Jul 2005 18:16:05 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 33357 invoked by uid 500); 21 Jul 2005 18:16:05 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 33249 invoked by uid 99); 21 Jul 2005 18:16:04 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jul 2005 11:16:04 -0700 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=FORGED_RCVD_HELO X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [207.155.252.12] (HELO sheffield.cnchost.com) (207.155.252.12) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jul 2005 11:15:59 -0700 Received: from rcsv650.rowe-clan.net (c-24-13-128-132.hsd1.il.comcast.net [24.13.128.132]) by sheffield.cnchost.com id OAA28974; Thu, 21 Jul 2005 14:16:00 -0400 (EDT) [ConcentricHost SMTP Relay 1.17] Errors-To: Message-Id: <6.2.1.2.2.20050721124607.08595480@pop3.rowe-clan.net> X-Mailer: QUALCOMM Windows Eudora Version 6.2.1.2 Date: Thu, 21 Jul 2005 12:49:41 -0500 To: Henry Jen , E Holyat From: "William A. Rowe, Jr." Subject: Re: [VOTE] APR 1.2.0 Cc: dev@apr.apache.org In-Reply-To: <42DEC896.1060004@ztune.net> References: <20050720204753.93478.qmail@web30006.mail.mud.yahoo.com> <42DEC896.1060004@ztune.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N At 04:56 PM 7/20/2005, Henry Jen wrote: >Good catch, you also need to reset cond->signalled. >I adapted your changes on the "else if" also the static INLINE internal function and created a new patch. This is definitely coolness; do you two agree this is the complete patch for locks/win32/thread_cond.c? If so, I'll commit this flavor in a couple hours after you both look it over one last time. I'm afraid, never having used condvars, that I'm not 100% certain about the expected behavior, so I'm not the best reviewer. Thanks to you both for spending cycles examining this code. FYI - in the future be careful to tag [PATCH apr-1.2] or something in the subject so that patches aren't lost in the noise of a longer conversation. Bill