apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bri...@brianp.net>
Subject Re: svn commit: r219285 - /apr/apr/branches/1.1.x/STATUS
Date Tue, 19 Jul 2005 06:17:38 GMT
Thanks.  Are you +1 for backporting to both apr-1.1 and apr-1.0?  (I  
put in a separate
vote in 1.0's STATUS file, since that has the same code for creating  
the pollset.)

Can a couple of other cast votes on this?

Thanks,
Brian

On Jul 15, 2005, at 11:13 PM, William A. Rowe, Jr. wrote:

> ++1 - obviously there are some heuristics to determine which
> is the win - but you've identified a pretty clear case where
> our preemptive strategy for creating a pollset was 'a bad idea' :)
>
>
>> +  *) Backport r209931 from 1.2 development trunk:
>> +     "Switch to lazy initialization of the pollset that's used  
>> within
>> +     apr_file_t on platforms where apr_wait_for_io_or_timeout()  
>> doesn't
>> +     use poll(2).  (This fixes a performance problem observed in  
>> httpd-2.x
>> +     on OS X due to the use of poll now being disabled by default  
>> on that
>> +     platform.)"
>> +        +1: brianp
>> +         0:
>> +        -1:
>>
>> CURRENT test/testall -v EXCEPTIONS:
>>
>>
>
>
>


Mime
View raw message