apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [VOTE] APR 1.2.0
Date Thu, 21 Jul 2005 17:49:41 GMT
At 04:56 PM 7/20/2005, Henry Jen wrote:

>Good catch, you also need to reset cond->signalled.
>I adapted your changes on the "else if" also the static INLINE internal function and created
a new patch.

This is definitely coolness; do you two agree this is the complete
patch for locks/win32/thread_cond.c?  If so, I'll commit this flavor
in a couple hours after you both look it over one last time.

I'm afraid, never having used condvars, that I'm not 100% certain
about the expected behavior, so I'm not the best reviewer.  Thanks
to you both for spending cycles examining this code.

FYI - in the future be careful to tag [PATCH apr-1.2] or something
in the subject so that patches aren't lost in the noise of a longer
conversation.

Bill  


Mime
View raw message