apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] vformatter formatting apr_status_t
Date Tue, 05 Jul 2005 19:24:20 GMT
On Tue, Jul 05, 2005 at 01:58:41PM -0500, William Rowe wrote:
> At 11:10 AM 7/5/2005, Joe Orton wrote:
> >Since 1.2.0 already adds one of these, why not another...
> >
> >glibc has a %m format string which is which expands to strerror(); this 
> >adds an equivalent %%pm which takes a pointer to an apr_status_t and 
> >prints the appropriate error string for that error code.
> 
> +1 in principal.
> 
> -1 on the whole %% abuse, it's is the wrong convention.  %% is supposed
> to be a literal '%', and abusing it for subclassing a long list of
> specialized formats was wrong.  We need to drop a '%' from that,
> restoring the meaning of %% in the format string, no?

Sorry s/%%pm/%pm/ in my message, %% is and always has been an escaped %.  
I just brainoed it after writing the doxygen string which also 
confusingly escapes the %s.

joe

Mime
View raw message