Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 75483 invoked from network); 5 Jun 2005 04:25:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Jun 2005 04:25:21 -0000 Received: (qmail 50625 invoked by uid 500); 5 Jun 2005 04:25:20 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 50583 invoked by uid 500); 5 Jun 2005 04:25:19 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 50569 invoked by uid 99); 5 Jun 2005 04:25:19 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=FORGED_RCVD_HELO X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from out-1.mail.amis.net (HELO out-1.mail.amis.net) (212.18.32.4) by apache.org (qpsmtpd/0.28) with ESMTP; Sat, 04 Jun 2005 21:25:18 -0700 Received: from localhost (in-4.mail.amis.net [212.18.32.23]) by out-1.mail.amis.net (Postfix) with ESMTP id 14CA05B52CE for ; Sun, 5 Jun 2005 06:25:14 +0200 (CEST) Received: from in-4.mail.amis.net ([127.0.0.1]) by localhost (in-4.mail.amis.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 42915-01 for ; Sun, 5 Jun 2005 06:25:12 +0200 (CEST) Received: from smtp.amis.net (smtp.amis.net [212.18.32.41]) by in-4.mail.amis.net (Postfix) with ESMTP id 294D64ADA97 for ; Sun, 5 Jun 2005 06:25:12 +0200 (CEST) Received: from palantir.xbc.nu (cpe-212-18-56-180.cable.amis.net [212.18.56.180]) by smtp.amis.net (Postfix) with SMTP id E45AC396803 for ; Sun, 5 Jun 2005 06:25:11 +0200 (CEST) Received: (qmail 32242 invoked from network); 5 Jun 2005 04:25:11 -0000 Received: from unknown (HELO ?172.17.19.19?) (172.17.19.19) by mx.xbc.nu with SMTP; 5 Jun 2005 04:25:11 -0000 Message-ID: <42A27EAA.90905@xbc.nu> Date: Sun, 05 Jun 2005 06:25:14 +0200 From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= Reply-To: dev@apr.apache.org User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Henry Jen CC: dev@apr.apache.org Subject: Re: Missing WaitForSingleObject on apr_thread_cont's mutex? References: <1117571915.5587.14.camel@hammerhead.sfbay.sun.com> In-Reply-To: <1117571915.5587.14.camel@hammerhead.sfbay.sun.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at amis.net X-Spam-Status: No, hits=-2.591 required=5 tests=[AWL=0.008, BAYES_00=-2.599] X-Spam-Level: X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Henry Jen wrote: >Hi, > >I was looking at the apr_thread_cond.c, and wondering if the >apr_thread_cond_wait & apr_thread_cond_timedwait code is missing a >WaitForSingleObject call on the mutex. Would someone share some light >with me? :-) > >The following is code snippet from the SVN trunk, and it seems to be >same as in apr-0.9.6. Comments in the code. > > The whole condition variable thing is broken on Windows. It has more race conditions than (insert faviourite expression). Adding a lock won't help. Someone has to rewrite the whole thing. (I'd actually started doing that at one point, but dropped it. Lack of time, etc.) -- Brane