apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Jen <henry...@ztune.net>
Subject [patch] Deadlock in apr_thread_cond_wait on WIN32 platform [BugID 27654, 34336]
Date Fri, 03 Jun 2005 06:05:20 GMT
Hi,

We encountered the issue as reported in Bug
27654(http://issues.apache.org/bugzilla/show_bug.cgi?id=27654), too bad
I did not check the issue database earlier until I figured it out after
3 days.

The patch in the issues database should be working, is there a reason
for not committing it?

Anyway, I have created another patch(see attachment) to address the same
issue and which would also fix bug 34336 as it totally removing the
cond->mutex. I believe using the mutex passed in to ensure mutual access
should be sufficient.

Unless the different threads can use different mutex for the same cond,
but I don't see that as a valid usage and nor can I think of a use case
for that.

Please review it, comments are welcome. I would like to see the patch be
committed to head and also back port to 0.9.x release. The patch had
been tested for both apr-0.9.6 and SVN trunk with 'patch -Np0' in the
apr folder.
 
Cheers,
-- 
Henry Jen aka slowhog
http://blogs.sun.com/slowhog

Mime
View raw message