From dev-return-14247-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed May 25 06:50:17 2005 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 90031 invoked from network); 25 May 2005 06:50:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 25 May 2005 06:50:17 -0000 Received: (qmail 47139 invoked by uid 500); 25 May 2005 06:50:15 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 47099 invoked by uid 500); 25 May 2005 06:50:15 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 47086 invoked by uid 99); 25 May 2005 06:50:15 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 24 May 2005 23:50:13 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j4P6oAqW015572 for ; Wed, 25 May 2005 02:50:10 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j4P6o9O24959 for ; Wed, 25 May 2005 02:50:09 -0400 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.13.1/8.12.7) with ESMTP id j4P6o3Yr008073 for ; Wed, 25 May 2005 07:50:03 +0100 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.13.1/8.12.10/Submit) id j4P6o3YT008072 for dev@apr.apache.org; Wed, 25 May 2005 07:50:03 +0100 Date: Wed, 25 May 2005 07:50:03 +0100 From: Joe Orton To: dev@apr.apache.org Subject: Re: svn commit: r178386 - /apr/apr/trunk/build/apr_hints.m4 Message-ID: <20050525065003.GA7561@redhat.com> Mail-Followup-To: dev@apr.apache.org References: <20050525062420.83107.qmail@minotaur.apache.org> <42941B22.8030404@force-elite.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <42941B22.8030404@force-elite.com> User-Agent: Mutt/1.4.1i X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Tue, May 24, 2005 at 11:28:50PM -0700, Paul Querna wrote: > jorton@apache.org wrote: > > Author: jorton > > Date: Tue May 24 23:24:19 2005 > > New Revision: 178386 > > > > URL: http://svn.apache.org/viewcvs?rev=178386&view=rev > > Log: > > * build/apr_hints.m4 (APR_PRELOAD): Prevent use of poll() on Darwin. > > I believe this should only apply to Darwin <8.0 or Mac OSX <10.4.0. > > poll() is known to be broken on the older versions, but it appears to > work correctly in 10.4. Al Begley @ Apple does not concur: http://issues.apache.org/bugzilla/show_bug.cgi?id=34332#c15 neither does the fact that everywhere I keep reading that poll() is "deprecated" on Darwin and is implemented as a wrapper for select() in libc. Or did that change in 10.4? > This could all be mute if we added a KQueue backend for apr_poll(). I > had the code to do it at one time, I will look at adding it later this week. apr_poll() is not used by apr_wait_for_io_or_timeout(). But making apr_poll() use a kqueue-like interface is a really bad idea anyway, as I've argued before. apr_poll() should be efficient to use occasionally or for small numbers of fds; and will be necessarily faster than apr_pollset_* in those cases since it requires just one system call - no overhead for setting up and tearing down the kqueue/epoll/... interface. Regards, joe