From dev-return-14148-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed May 04 14:14:30 2005 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 97274 invoked from network); 4 May 2005 14:14:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 May 2005 14:14:30 -0000 Received: (qmail 88832 invoked by uid 500); 4 May 2005 14:15:21 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 88745 invoked by uid 500); 4 May 2005 14:15:20 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 88665 invoked by uid 99); 4 May 2005 14:15:18 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of jorton@redhat.com designates 66.187.233.31 as permitted sender) Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 04 May 2005 07:15:18 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j44ED7w6027454 for ; Wed, 4 May 2005 10:13:07 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j44ED2O02912 for ; Wed, 4 May 2005 10:13:02 -0400 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.13.1/8.12.7) with ESMTP id j44ED09U025273 for ; Wed, 4 May 2005 15:13:01 +0100 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.13.1/8.12.10/Submit) id j44ED0VD025272 for dev@apr.apache.org; Wed, 4 May 2005 15:13:00 +0100 Date: Wed, 4 May 2005 15:12:59 +0100 From: Joe Orton To: dev@apr.apache.org Subject: Re: [PATCH] Fix apr_table_overlap when pools aren't the same Message-ID: <20050504141259.GA25123@redhat.com> Mail-Followup-To: dev@apr.apache.org References: <87ll8qs0zh.fsf@gemini.sunstarsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87ll8qs0zh.fsf@gemini.sunstarsys.com> User-Agent: Mutt/1.4.1i X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Mon, Mar 14, 2005 at 10:25:54AM -0500, Joe Schaefer wrote: > Here's a semi-tested patch to fix apr_table_overlap when > the pools differ. The current code wipes out the first > argument's table when the pools differ, which is clearly > inconsistent with the documented behavior (my fault probably, > because I think this bug is due to an old patch of mine). Thanks a lot, I've committed this. > I say "semi-tested" because the patch I wanted to submit > would change all the POOL_DEBUG ifdefs in apr_tables.c > to APR_POOL_DEBUG, but when I tested that against httpd's trunk > there were lots of core files being generated. When I tried to > write a patch for httpd, I noticed that apr_pool_join doesn't > work (not implemented by apr), so at the moment I'm not sure > if apr has abandoned the goal of being strict about pool ancenstry > in the table ops. After filling in the gaps in the pools code it does seem to work OK. Do you see any problems with the trunk? Regards, joe