apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <c...@force-elite.com>
Subject Re: svn commit: r167847 - in /apr/apr/trunk: CHANGES configure.in include/apr.h.in misc/unix/rand.c
Date Wed, 04 May 2005 19:43:11 GMT
Joe Orton wrote:
> On Tue, May 03, 2005 at 02:01:13AM -0000, Paul Querna wrote:
> 
>>Author: pquerna
>>Date: Mon May  2 19:01:12 2005
>>New Revision: 167847
>>
>>URL: http://svn.apache.org/viewcvs?rev=167847&view=rev
>>Log:
>>- Add support for uuid_generate on OS X 10.4.  This required some extra foot
>>work since Apple put the uuid_generate functions into their libc, while Linux
>>keeps them in libuuid.
> 
> ...
> 
>>Modified: apr/apr/trunk/include/apr.h.in
>>URL: http://svn.apache.org/viewcvs/apr/apr/trunk/include/apr.h.in?rev=167847&r1=167846&r2=167847&view=diff
>>==============================================================================
>>--- apr/apr/trunk/include/apr.h.in (original)
>>+++ apr/apr/trunk/include/apr.h.in Mon May  2 19:01:12 2005
>>@@ -101,6 +101,8 @@
>> #define APR_HAVE_SYS_WAIT_H      @sys_waith@
>> #define APR_HAVE_TIME_H          @timeh@
>> #define APR_HAVE_UNISTD_H        @unistdh@
>>+#define APR_HAVE_UUID_UUID_H     @uuid_uuidh@
>>+#define APR_HAVE_UUID_H          @uuidh@
> 
> 
> I'll keep banging this drum:
> 
> why are you exporting these definitions?

I did it because thats what every other header in the misc/unix/rand.c
file does:

#if APR_HAVE_SYS_TYPES_H
#include <sys/types.h>
#endif
#if APR_HAVE_SYS_SOCKET_H
#include <sys/socket.h>
#endif
#if APR_HAVE_FCNTL_H
#include <fcntl.h>
#endif
#if APR_HAVE_UNISTD_H
#include <unistd.h>
#endif
#if APR_HAVE_SYS_UN_H
#include <sys/un.h>
#endif


> Any definition which is only
> needed internally to APR should just be AC_CHECK_HEADERS'd and not
> exported via apr.h (doing this for only one of the myriad apr.h's is
> inconsistent if nothing else)

I was trying to be consistent, but I agree with you, and I will change
it to an AC_CHECK_HEADER.

-Paul

Mime
View raw message