apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] Fix apr_table_overlap when pools aren't the same
Date Wed, 04 May 2005 14:12:59 GMT
On Mon, Mar 14, 2005 at 10:25:54AM -0500, Joe Schaefer wrote:
> Here's a semi-tested patch to fix apr_table_overlap when
> the pools differ.  The current code wipes out the first
> argument's table when the pools differ, which is clearly
> inconsistent with the documented behavior (my fault probably,
> because I think this bug is due to an old patch of mine).

Thanks a lot, I've committed this.

> I say "semi-tested" because the patch I wanted to submit
> would change all the POOL_DEBUG ifdefs in apr_tables.c 
> to APR_POOL_DEBUG, but when I tested that against httpd's trunk
> there were lots of core files being generated.  When I tried to
> write a patch for httpd, I noticed that apr_pool_join doesn't
> work (not implemented by apr), so at the moment I'm not sure 
> if apr has abandoned the goal of being strict about pool ancenstry 
> in the table ops.

After filling in the gaps in the pools code it does seem to work OK.  Do
you see any problems with the trunk?

Regards,

joe

Mime
View raw message