Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (hermes.apache.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Mon, 25 Apr 2005 13:16:36 +0100
From: Joe Orton <jorton@redhat.com>
To: Brian Havard <brianh@kheldar.apana.org.au>
Cc: APR developers <dev@apr.apache.org>
Subject: Re: Using OpenSSL's des_fcrypt for thread safe crypt()
Message-ID: <20050425121636.GC20419@redhat.com>
Mail-Followup-To: Brian Havard <brianh@kheldar.apana.org.au>,
	APR developers <dev@apr.apache.org>
References: <E1DQ2Md-000093-00@silk.apana.org.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <E1DQ2Md-000093-00@silk.apana.org.au>
User-Agent: Mutt/1.4.1i

On Mon, Apr 25, 2005 at 10:06:59PM +1000, Brian Havard wrote:
> I'd like to add to apr-util the ability to use des_fcrypt from the OpenSSL 
> library as a possible thread-safe implementation of crypt() for systems that 
> have no crypt_r().
> 
> Does anyone have a problem with either the concept or implementation of this?

With the implementation, at least, yes:
- only pick up the dependency on -lcrypto on platforms which need this
- keep the flag private to apr-util (i.e. use AC_CHECK_HEADERS and
AC_DEFINE), it doesn't need to be exported via apu.h

Is this function really thread-safe in OpenSSL even without the locking
callbacks registered?

Regards,

joe