apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] Don't define POSIX types {p,g,u}id_t
Date Wed, 27 Apr 2005 07:07:46 GMT
On Tue, Apr 26, 2005 at 08:47:25AM -0500, William Rowe wrote:
> At 08:24 AM 4/26/2005, Erik Huelsmann wrote:
> >On 4/26/05, Joe Orton <jorton@redhat.com> wrote:
> >>
> >> Will this not break programs on Windows which hitherto presumed that APR
> >> defines these types?  i.e. it breaks the source-compatibility API
> >> guarantee for APR 1.x?
> >
> >Yes, it does, if you consider that an APR api promise. I don't: I
> >consider it an unfortunate side effect of header file structuring (a
> >bug to be fixed): the APR type to use (in 1.1.x) always has been
> >apr_os_proc_t which serves the purpose of pid_t in a platform
> >independent way.
> 
> As 0.9 API is considered released/stable, backporting isn't an
> option.  We could replace with a #ifndef / #define construct,
> but in 0.9, the symbol has to remain.

Allowing the application to choose to suppress the typedefs with
something like:

#ifndef APR_DONT_DEFINE_PGUID_T
...
#endif

wouldn't really break the API guarantee for 0.9.x or 1.x, I suppose.

joe

Mime
View raw message