Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (hermes.apache.org: local policy)
Date: Fri, 18 Mar 2005 09:00:26 -0800
From: Justin Erenkrantz <justin@erenkrantz.com>
To: Ryan Bloom <rbloom@gmail.com>
cc: Jeff Trawick <trawick@gmail.com>, dev@httpd.apache.org, dev@apr.apache.org
Subject: Re: do we still want sendfile enabled with our default conf files?
Message-ID: <E12FD057DC6201CABCA78574@[10.0.1.81]>
In-Reply-To: <1f1d982050318082726d1a8ad@mail.gmail.com>
References: <cc67648e05031704575741b217@mail.gmail.com>	
 <42398A5C.7000400@slive.ca>	 <20050317141250.GA28555@castlerea.stdlib.net.>	
 <20050317152754.GI5790@scotch.ics.uci.edu>	
 <cc67648e050317160175a8a153@mail.gmail.com>	
 <20050318013331.GO5790@scotch.ics.uci.edu>	
 <cc67648e0503180259929bc4@mail.gmail.com>	
 <CE3CD595B8676A3F6F4E5BD5@10.0.1.81>	
 <1f1d98205031808126698802b@mail.gmail.com>	
 <6A59038878FF133648C83BDC@10.0.1.81>
 <1f1d982050318082726d1a8ad@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--On Friday, March 18, 2005 11:27 AM -0500 Ryan Bloom <rbloom@gmail.com> wrote:

> That's fine.  Pay attention to what I suggested.  Default to
> non-native sendfile, until we have know that it works.  If you have an
> OS that you know for a fact does sendfile correctly, then that would
> be a case where we know that it works.

I tend to prefer Jeff's solution of having APR return APR_ENOTIMPL when the 
APR_SENDFILE_AUTODETECT flag is set and we'd fail.  I'm ambivalent if we 
decide to have apr_socket_sendfile() internally call emulate_sendfile because 
apr_socket_sendfile() has always been an optional function (APR_HAS_SENDFILE). 
If we go this route of having it mask the choice, then apr_socket_sendfile() 
should always be present and we can clean up the code in httpd accordingly.

I also think that we likely already know the cases when sendfile is going to 
succeed on a particular platform.  I haven't heard any claims that sendfile() 
fails on Linux when using only IPv4 and ext{23}.  So, yes, I think we can do 
better than a straight APR_ENOTIMPL - but if people don't want to write the 
checks, then we'll just live with writev() on that platform.  -- justin