From dev-return-13873-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Fri Mar 11 20:36:23 2005
Return-Path: <dev-return-13873-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
Delivered-To: apmail-apr-dev-archive@www.apache.org
Received: (qmail 22390 invoked from network); 11 Mar 2005 20:36:23 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 11 Mar 2005 20:36:23 -0000
Received: (qmail 13806 invoked by uid 500); 11 Mar 2005 20:36:22 -0000
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 13769 invoked by uid 500); 11 Mar 2005 20:36:22 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Subscribe: <mailto:dev-subscribe@apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 13755 invoked by uid 99); 11 Mar 2005 20:36:22 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from ares.cs.Virginia.EDU (HELO ares.cs.Virginia.EDU) (128.143.137.19)
  by apache.org (qpsmtpd/0.28) with ESMTP; Fri, 11 Mar 2005 12:36:20 -0800
Received: from cobra.cs.Virginia.EDU (cobra.cs.Virginia.EDU [128.143.137.16])
	by ares.cs.Virginia.EDU (8.13.3/8.12.10/UVACS-2003031900) with ESMTP id j2BKaGOP027736;
	Fri, 11 Mar 2005 15:36:16 -0500 (EST)
Date: Fri, 11 Mar 2005 15:36:16 -0500 (EST)
From: Cliff Woolley <jwoolley@virginia.edu>
X-X-Sender: jcw5q@cobra.cs.Virginia.EDU
To: Joe Schaefer <joe+gmane@sunstarsys.com>
cc: dev@apr.apache.org
Subject: Re: When to call apr_bucket_alloc_destroy?
In-Reply-To: <87fyz2j5ul.fsf@gemini.sunstarsys.com>
Message-ID: <Pine.GSO.4.58.0503111535450.9266@cobra.cs.Virginia.EDU>
References: <87y8cvl8mn.fsf@gemini.sunstarsys.com> <87fyz2j5ul.fsf@gemini.sunstarsys.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N


> @@ -46,6 +46,13 @@
>      apr_bucket_alloc_t *list = data;
>
>      apr_allocator_free(list->allocator, list->blocks);
> +
> +#if APR_POOL_DEBUG
> +    if (list->pool && list->allocator != apr_pool_allocator_get(list->pool)) {
> +        apr_allocator_destroy(list->allocator);
> +    }
> +#endif
> +
>      return APR_SUCCESS;
>  }


+1, thanks.