apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: [PATCH] add APR_SENDFILE_AUTODETECT programming interface
Date Fri, 18 Mar 2005 19:06:02 GMT
--On Friday, March 18, 2005 1:54 PM -0500 Jeff Trawick <trawick@gmail.com> 
wrote:

> Applications turn on this flag if they want to avoid any sendfile
> bogosity, which can be triggered based on hardware or software or
> configuration.

Looks fine to me.  Thanks!

> Alternate strategy: APR internally implements the sendfile interface
> using other mechanisms, such that applications don't need to check for
> APR_ENOTIMPL.

I would treat this as an orthogonal (sub-)problem.  We should always define 
APR_HAS_SENDFILE and move in the logic for emulating sendfile into 
apr_socket_sendfile.  This would clean up a major wart in our interfaces that 
we should have dealt with long ago and enables us not to have to return 
APR_ENOTIMPL.

Yet, this can be treated separately from any _AUTODETECT code.

Does that make sense?  -- justin

Mime
View raw message