Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (hermes.apache.org: local policy)
Date: Fri, 14 Jan 2005 09:11:14 -0800
From: Justin Erenkrantz <justin@erenkrantz.com>
To: Colm MacCarthaigh <colm@stdlib.net>
Cc: Julian Foad <julianfoad@btopenworld.com>, dev@apr.apache.org
Subject: Re: Whitespace and patches WAS Re: [Patch] SSM support for
 multicast.c
Message-ID: <20050114171114.GG12871@scotch.ics.uci.edu>
Mail-Followup-To: Justin Erenkrantz <justin@erenkrantz.com>,
	Colm MacCarthaigh <colm@stdlib.net>,
	Julian Foad <julianfoad@btopenworld.com>, dev@apr.apache.org
References: <20050104145319.GA22784@castlerea.stdlib.net.>
 <41E41A35.1060907@btopenworld.com>
 <20050111231924.GA32246@castlerea.stdlib.net.>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050111231924.GA32246@castlerea.stdlib.net.>
User-Agent: Mutt/1.5.6i

On Tue, Jan 11, 2005 at 11:19:25PM +0000, Colm MacCarthaigh wrote:
> But anyway, which is worse? 
> 
> 	1. Submitting patches that are broken (or at best semi-broken) 
> 	   style-wise.
> 
> 	2. Submitting patches with some whitespace fixes in-line
> 	   (like the one I submitted).
> 
> 	3. Checking first, to see if it's style-compliant, running
> 	   the indenter/whatever, producing a pure whitespace patch,
> 	   adding whatever code and then producing that patch and
> 	   submitting both.
> 
> I realise there's secret option 4 - just code in the Apache style - is
> the ideal-case but honestly I just can't productively cope with 4-space
> indents ;) Doing so usually causes me to take 10 times as long and make
> twice as many non-style errors.

As Julian implied, #3 is okay.  #4 is best.  #1 or #2 aren't going to be
accepted for the most part.  -- justin