From dev-return-13536-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Jan 11 18:26:07 2005 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 45511 invoked from network); 11 Jan 2005 18:26:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 11 Jan 2005 18:26:06 -0000 Received: (qmail 83564 invoked by uid 500); 11 Jan 2005 18:26:05 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 83527 invoked by uid 500); 11 Jan 2005 18:26:05 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 83513 invoked by uid 99); 11 Jan 2005 18:26:05 -0000 X-ASF-Spam-Status: No, hits=1.8 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from A.painless.aaisp.net.uk (HELO smtp.aaisp.net.uk) (81.187.81.51) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 11 Jan 2005 10:26:03 -0800 Received: from [81.187.191.242] (helo=[81.187.191.242]) by smtp.aaisp.net.uk with esmtp (Exim 4.42) id 1CoQiO-0005H1-Kp; Tue, 11 Jan 2005 18:26:00 +0000 Message-ID: <41E41A35.1060907@btopenworld.com> Date: Tue, 11 Jan 2005 18:25:57 +0000 From: Julian Foad User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a5) Gecko/20041122 X-Accept-Language: en-gb, en, en-us MIME-Version: 1.0 To: colm@stdlib.net CC: dev@apr.apache.org Subject: Re: [Patch] SSM support for multicast.c References: <20050104145319.GA22784@castlerea.stdlib.net.> In-Reply-To: <20050104145319.GA22784@castlerea.stdlib.net.> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Colm MacCarthaigh wrote: > Patch also contains some whitespace/style cleanups my editor applied > (uggh) [...] When you do a significant amount of whitespace cleanup, like in this patch, it is better to send the cleanup and the functional change as two separate patches. (e.g. Load the original file, clean it, save it. Then send the diff from original to that as a cleanup patch, and the diff from that to your functionally changed version as the functional patch.) The combined patch is hard to review because it has lots of irrelevant bits in it. - Julian