apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <julianf...@btopenworld.com>
Subject Re: [Patch] SSM support for multicast.c
Date Tue, 11 Jan 2005 18:25:57 GMT
Colm MacCarthaigh wrote:
> Patch also contains some whitespace/style cleanups my editor applied
> (uggh) [...]

When you do a significant amount of whitespace cleanup, like in this patch, it 
is better to send the cleanup and the functional change as two separate 
patches.  (e.g. Load the original file, clean it, save it.  Then send the diff 
from original to that as a cleanup patch, and the diff from that to your 
functionally changed version as the functional patch.)  The combined patch is 
hard to review because it has lots of irrelevant bits in it.

- Julian

View raw message