apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <julianf...@btopenworld.com>
Subject Re: svn commit: r124243 - /apr/apr/trunk/random/unix/sha2.c
Date Tue, 11 Jan 2005 18:19:54 GMT
William A. Rowe, Jr. wrote:
> Can I have a second set of eyes for a reality check before
> I backport this compile-time cleanup?

It looks fine to me, if you think it is appropriate to back-port such a clean-up.

The log message is rather difficult to understand.

- Julian


[...]
>>Log:
>>
>> Clean up 4 extranious emits.  Because of the modulo operator, these
>> becomes safe casts to unsigned.
[...]
>>-        usedspace = (context->bitcount >> 3) % SHA256_BLOCK_LENGTH;
>>+        usedspace = (unsigned int)((context->bitcount >> 3) 
>>+                                 % SHA256_BLOCK_LENGTH);
[...]


Mime
View raw message