apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm MacCarthaigh <c...@stdlib.net>
Subject Re: [PATCH] LDAP option_set_tls should return a value
Date Thu, 20 Jan 2005 13:53:24 GMT
On Thu, Jan 20, 2005 at 03:42:18PM +0200, Graham Leggett wrote:
> Colm MacCarthaigh said:
> 
> > This isn't win32 specific, which is why it isn't in the other patch,
> > but it's a trivial fix. option_set_tls never actually returns anything.
> 
> The return codes are passed back inside the result_err structure,
> apr_ldap_*_option() returns either APR_SUCCESS or APR_EGENERAL depending
> on whether the underlying LDAP call was successful or not.
> 
> Is there a specific case where this is not happening?

No, but the function is typed int, and it doesn't return ever one :)
Either return result->rc, like option_set_cert, or make the function
void :) But you can't have it both ways.

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Mime
View raw message