apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jus...@erenkrantz.com>
Subject Re: Whitespace and patches WAS Re: [Patch] SSM support for multicast.c
Date Fri, 14 Jan 2005 17:11:14 GMT
On Tue, Jan 11, 2005 at 11:19:25PM +0000, Colm MacCarthaigh wrote:
> But anyway, which is worse? 
> 
> 	1. Submitting patches that are broken (or at best semi-broken) 
> 	   style-wise.
> 
> 	2. Submitting patches with some whitespace fixes in-line
> 	   (like the one I submitted).
> 
> 	3. Checking first, to see if it's style-compliant, running
> 	   the indenter/whatever, producing a pure whitespace patch,
> 	   adding whatever code and then producing that patch and
> 	   submitting both.
> 
> I realise there's secret option 4 - just code in the Apache style - is
> the ideal-case but honestly I just can't productively cope with 4-space
> indents ;) Doing so usually causes me to take 10 times as long and make
> twice as many non-style errors.

As Julian implied, #3 is okay.  #4 is best.  #1 or #2 aren't going to be
accepted for the most part.  -- justin

Mime
View raw message