Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (hermes.apache.org: local policy)
Message-ID: <41B9389D.4030803@xbc.nu>
Date: Fri, 10 Dec 2004 06:48:13 +0100
From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu>
User-Agent: Mozilla Thunderbird 0.9 (Windows/20041103)
MIME-Version: 1.0
To: Nick Kew <nick@webthing.com>
Cc: dev@apr.apache.org
Subject: Re: apr_dbd: a generic SQL wrapper
References: <Pine.LNX.4.53.0412061811080.1181@hugin.webthing.com>
 <Pine.LNX.4.53.0412091219060.6831@hugin.webthing.com>
 <41B9081D.7080706@xbc.nu>
 <Pine.LNX.4.53.0412100535050.3423@hugin.webthing.com>
In-Reply-To: <Pine.LNX.4.53.0412100535050.3423@hugin.webthing.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Nick Kew wrote:

>On Fri, 10 Dec 2004, Branko �^Libej wrote:
>
>  
>
>>Nick Kew wrote:
>>
>>    
>>
>>>/* These are opaque structs.  Instantiation is up to each backend */
>>>#ifndef APR_DBD_INTERNAL
>>>typedef struct apr_dbd_t apr_dbd_t;
>>>typedef struct apr_dbd_transaction apr_dbd_transaction;
>>>typedef struct apr_dbd_results apr_dbd_results;
>>>typedef struct apr_dbd_row apr_dbd_row;
>>>typedef struct apr_dbd_prepared apr_dbd_prepared;
>>>#endif
>>>
>>>
>>>      
>>>
>>If these are truly internal, they shouldn't be declared in the public
>>header, even #ifdefed out. That's a small nit, but I thought I'd mention
>>ti since it leaped out at me.
>>    
>>
>
>They're not internal.  Applications need to know them all to pass to
>functions in the API.  It's the instantiations that are internal.
>
>The #ifndef is because *drivers* have to declare them before
>#including apr_dbd.h.
>  
>
They don't have to declare them before including the header. This 
sequence is completely valid:

    typedef struct foo foo;

    struct foo {
       int bar;
    };

IOW, the typedef serves as a forward declaration of the structure. So 
that #ifdef can go away.

-- Brane