apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r109832 -
Date Sun, 05 Dec 2004 14:10:52 GMT
On Sun, 05 Dec 2004 00:01:05 -0700, Paul Querna <chip@force-elite.com> wrote:
> Jeff Trawick wrote:
>   > we're hosed here if apr_file_write() can only write part of the data
> > (tbytes is < vec[i].iov_len and rv is APR_SUCCESS); don't you also
> > need to bail if tbytes < vec[i].iov_len?
> 
> Committed r109865 which uses apr_file_write_full() to hopefully write
> the entire iovec.
> 
> According to the docs for apr_file_write_full, if it returns in an error
>   condition, you should add the number of bytes written.

1) write_full() has the wrong semantics for apr_file_writev();
apr_file_writev() and apr_file_write() are not supposed to block

2) fix the code formatting

Mime
View raw message