apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@xbc.nu>
Subject Re: apr_dbd: a generic SQL wrapper
Date Fri, 10 Dec 2004 02:21:17 GMT
Nick Kew wrote:

>/* These are opaque structs.  Instantiation is up to each backend */
>#ifndef APR_DBD_INTERNAL
>typedef struct apr_dbd_t apr_dbd_t;
>typedef struct apr_dbd_transaction apr_dbd_transaction;
>typedef struct apr_dbd_results apr_dbd_results;
>typedef struct apr_dbd_row apr_dbd_row;
>typedef struct apr_dbd_prepared apr_dbd_prepared;
>#endif
>  
>
If these are truly internal, they shouldn't be declared in the public 
header, even #ifdefed out. That's a small nit, but I thought I'd mention 
ti since it leaped out at me.

-- Brane



Mime
View raw message