From dev-return-13213-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Nov 23 01:43:39 2004 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 58673 invoked from network); 23 Nov 2004 01:43:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 23 Nov 2004 01:43:38 -0000 Received: (qmail 71455 invoked by uid 500); 23 Nov 2004 01:43:37 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 71408 invoked by uid 500); 23 Nov 2004 01:43:36 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 71391 invoked by uid 99); 23 Nov 2004 01:43:36 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy includes SPF record at spf.trusted-forwarder.org) X-pair-Authenticated: 24.44.79.162 Message-ID: <41A295C0.9090801@electricjellyfish.net> Date: Mon, 22 Nov 2004 20:43:28 -0500 From: Garrett Rooney User-Agent: Mozilla Thunderbird 0.8 (X11/20041012) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@apr.apache.org Subject: [PATCH] unused code in user/netware/userinfo.c Content-Type: multipart/mixed; boundary="------------080005050502000900060501" X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N This is a multi-part message in MIME format. --------------080005050502000900060501 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit I'm even more out of my area here than in win32 land, but it looks like user/netware/userinfo.c has some code that isn't actually being used. Specifically the getpwnam_safe function is statically defined, but never called (and doesn't do anything anyway), and the PWBUF_SIZE define is only used for one of the function arguments in getpwnam_safe. Here's a patch removing the code in question. -garrett --------------080005050502000900060501 Content-Type: text/plain; name="netware-userinfo-cleanup.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="netware-userinfo-cleanup.diff" Index: user/netware/userinfo.c =================================================================== --- user/netware/userinfo.c (revision 106112) +++ user/netware/userinfo.c (working copy) @@ -27,15 +27,6 @@ #include /* for _POSIX_THREAD_SAFE_FUNCTIONS */ #endif -#define PWBUF_SIZE 512 - -static apr_status_t getpwnam_safe(const char *username, - struct passwd *pw, - char pwbuf[PWBUF_SIZE]) -{ - return APR_ENOTIMPL; -} - APR_DECLARE(apr_status_t) apr_uid_homepath_get(char **dirname, const char *username, apr_pool_t *p) --------------080005050502000900060501--