apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: [PATCH] unused code in user/netware/userinfo.c
Date Tue, 23 Nov 2004 16:13:04 GMT
   You are right, it is dead code for now.  The reason why it is there
is because this file is just a stub rip-off of the Unix implementation. 
It is just waiting for the day when the NetWare OS supports UID/GID for
running applications and services.  On the NetWare OS applications and
services don't run as a user, they just run.  Therefore the underlying
APIs like getuid(), getgid() and getpwnam() don't exist on NetWare. 
Even if they did, they wouldn't return anything useful.  So for now,
this is just a stub implementation.

Brad

>>> Garrett Rooney <rooneg@electricjellyfish.net> Monday, November 22,
2004 6:43:28 PM >>>
I'm even more out of my area here than in win32 land, but it looks like

user/netware/userinfo.c has some code that isn't actually being used. 
Specifically the getpwnam_safe function is statically defined, but
never 
called (and doesn't do anything anyway), and the PWBUF_SIZE define is 
only used for one of the function arguments in getpwnam_safe.

Here's a patch removing the code in question.

-garrett

Mime
View raw message