apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject Re: svn commit: r106214 - /apr/apr/trunk/CHANGES /apr/apr/trunk/configure.in /apr/apr/trunk/include/apr.h.in /apr/apr/trunk/misc/unix/rand.c
Date Mon, 22 Nov 2004 23:18:12 GMT
On Mon, 22 Nov 2004, Julian Foad wrote:

> Joe Orton wrote:
> > On Mon, Nov 22, 2004 at 08:14:26PM -0000, Paul Querna wrote:
> >>+    memcpy( (void*)uuid_data, (const void *)&g, sizeof( uuid_t ) );
> >
> > Please watch the code style, Paul!
>
> Not sure exactly what Joe is referring to, but note that it should never be
> necessary to cast anything to "const void *" - the whole point of accepting
> "const void *" is that it means "accept pointers to anything, writable or not".
>   You don't need to cast to "void *" either unless the value you're casting was
> a pointer to const and you're casting away the "const".

Yes, the casts are unnecessary.  The other style problem to which Joe was
referring is the whitespace.  By Apache style, it should read:

    memcpy(uuid_data, &g, sizeof(uuid_t));

--Cliff

Mime
View raw message