apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: svn commit: r106663 - /apr/apr/trunk/CHANGES /apr/apr/trunk/include/apr_file_io.h
Date Mon, 29 Nov 2004 16:50:14 GMT
William A. Rowe, Jr. wrote:
> At 03:26 PM 11/26/2004, you wrote:
>>Author: stas
>>Date: Fri Nov 26 13:26:37 2004
>>New Revision: 106663
>>URL: http://svn.apache.org/viewcvs?view=rev&rev=106663
>>rename the fopen defines (APR_READ, APR_WRITE, etc.) to have prefix 
>>APR_FOPEN_ (keeping the old defines)
> Stas, you forgot doxygen @deprecate tags!  For example, with;

In my last patch I've asked:

 > Should there be some deprecation tags for doxygen in it?

and received no follow up, so I've commited what I've proposed.

>>+#define APR_FOPEN_READ       0x00001  /**< Open the file for reading */
> we need a matching doxygen entry redirecting the user;
>>+#define APR_READ  APR_FOPEN_READ  /**< @deprecated @see APR_FOPEN_READ */
> This provides documentation that devs *need* to track the changes.

Thanks, committed.

Also should the deprecated macros stay in this file or can those be moved 
to some dedicated file to reduce the noise?

Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

View raw message