apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@xbc.nu>
Subject Re: [PATCH] auto-generate apr.dsp and libapr.dsp files
Date Mon, 22 Nov 2004 01:29:56 GMT
Garrett Rooney wrote:

>+def win32ify_paths(paths):
>+  rpaths = []
> 
>+  for p in paths:
>+    segs = re.split('/', p)
>+    rp = '.\\' + string.join(segs, '\\')
>+    rpaths.append(rp)
>+
>+  return rpaths
>  
>
Hmmm....

    def win32ify_paths(paths):
        return map(lambda x: '.\\'+string.replace(x, '/', '\\'), paths)

Howzat? :-)

>+
>+
>+def do_windows(parser):
>+  subdirs = []
>+
>+  for subdir in string.split(parser.get('options', 'platform_dirs')):
>+    path = '%s/%s' % (subdir, 'win32')
>  
>
Why not

    path = os.path.join(subdir, 'win32')?

You do the win32ification later on anyway.

On the whole, it looks good. I'll give it a spin tomorrow. We can add 
the file groups later on (they're not necessary, but they do make it 
easier for the user).

Regarding the "lesser" dsps: I fully expect them to be generated later 
on, because we'll want to be able to create VS.NET .vcproj files, too.

-- Brane


Mime
View raw message