apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@xbc.nu>
Subject Re: [PATCH] Fix testing of "BEOS" symbol
Date Tue, 16 Nov 2004 06:42:33 GMT
Julian Foad wrote:

> Brane, you have caught me in zero-tolerance week.  Please bear with me 
> while I rant again.  :-)

:-)

I don't disagree with what you said, I was merely pointing out a (the?) 
potential catch. If the #if was an exception WRT the BEOS symbol, then 
your change is fine; but you should say so (perhaps you did in another 
post and I missed it; sorry).

Regarding #if vs. #ifdef in general, well, you noticed that most macros 
generated by configure are tested with #if, even though, IIRC, autoconf 
leaves them undefined rather than #defined to 0 if the predicate is 
false. If so, then always using -Wundef might actually be harmful 
because it would generate lots of false positives that people would 
start to ignore, and the rare true positives would slip through.

-- Brane



Mime
View raw message