apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] Remove unnecessary casting away of "const"
Date Tue, 16 Nov 2004 10:10:30 GMT
On Tue, Nov 16, 2004 at 04:58:34AM -0500, Jeff Trawick wrote:
> On Tue, 16 Nov 2004 07:02:47 +0000, Joe Orton <jorton@redhat.com> wrote:
> > On Mon, Nov 15, 2004 at 11:09:40PM +0000, Julian Foad wrote:
> > > Remove unnecessary type casts that were casting away "const".
> > > No functional change.
> > 
> > These ones aren't unnecessary, some compilers are more picky about
> > implicit signed char * -> unsigned char * conversion, so this will
> > introduce warnings (or possibly errors) with some compilers.
...
> except that apr_md5_update was changed to accept "const void *" and
> handle required char signed-ness internally to avoid bothering callers
> with this sort of nonsense; the missing piece seems to be to remove
> those casts; ACK?

Ah sorry, I missed that.  I'll commit this then when the SVN repos comes
back online.

joe

Mime
View raw message